Skip to content

STYLE enable ruff PLR5501 #51709 #51747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Mar 7, 2023
Merged

STYLE enable ruff PLR5501 #51709 #51747

merged 19 commits into from
Mar 7, 2023

Conversation

ahmad-04
Copy link
Contributor

@ahmad-04 ahmad-04 commented Mar 2, 2023 •
edited
Loading

@MarcoGorelli MarcoGorelli self-requested a review March 2, 2023 20:40
@MarcoGorelli
Copy link
Member

well done! looks like there's a merge conflict, could you resolve it please?

@MarcoGorelli
Copy link
Member

hey - please check https://www.atlassian.com/git/tutorials/using-branches/merge-conflicts

MarcoGorelli
MarcoGorelli reviewed Mar 3, 2023
View reviewed changes
@ahmad-04
Copy link
Contributor Author

ahmad-04 commented Mar 3, 2023

Hey, I wanted to ask, what these errors are about I can't quite get it?

MarcoGorelli
MarcoGorelli reviewed Mar 3, 2023
View reviewed changes
MarcoGorelli
MarcoGorelli suggested changes Mar 3, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something's not quite right, tests are failing - please check the logic of each change

MarcoGorelli
MarcoGorelli reviewed Mar 3, 2023
View reviewed changes
ahmad-04
ahmad-04 commented Mar 3, 2023
View reviewed changes
Copy link
Contributor Author

@ahmad-04 ahmad-04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked all changes. Did change one u suggested other than that there were not any that i found.

@ahmad-04
Copy link
Contributor Author

ahmad-04 commented Mar 4, 2023

Hey, this new error is because of numpy i think. it is not being import for some reason.

@MarcoGorelli
Copy link
Member

yup, that one's unrelated - this should be good to go, I'll check again later, thanks!

@ahmad-04
Copy link
Contributor Author

ahmad-04 commented Mar 5, 2023

Hey @MarcoGorelli , did u find anything?

@mroeschke mroeschke added the Code Style Code style, linting, code_checks label Mar 6, 2023
MarcoGorelli
MarcoGorelli suggested changes Mar 7, 2023
View reviewed changes
@ahmad-04

This comment was marked as off-topic.

Sign in to view
@ahmad-04 ahmad-04 closed this Mar 7, 2023
@ahmad-04 ahmad-04 reopened this Mar 7, 2023
@ahmad-04
Copy link
Contributor Author

ahmad-04 commented Mar 7, 2023

Hey,
Thanks for advice and helping solve these issue checks cleared. what should I do next?

@MarcoGorelli
Copy link
Member

nothing, this looks ready, feel free to take on other issues if interested - I'll merge when I've had a chance to double-check everything

MarcoGorelli
MarcoGorelli approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice, thanks @ahmad2901 !

no need to do anything, I'll merge once the final jobs are green

@MarcoGorelli MarcoGorelli added this to the 2.1 milestone Mar 7, 2023
@MarcoGorelli MarcoGorelli merged commit 376f77d into pandas-dev:main Mar 7, 2023
@ahmad-04 ahmad-04 deleted the shiny-new-feature branch March 8, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

STYLE enable ruff PLR5501
3 participants
@ahmad-04 @MarcoGorelli @mroeschke